Skip to content

/ mapbox-java

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use uuid in Map Matching response #1174

Open
danpaz opened this issue Sep 2, 2020 · 1 comment
Open

Use uuid in Map Matching response #1174

danpaz opened this issue Sep 2, 2020 · 1 comment

Comments

@danpaz
Copy link
Member

@danpaz danpaz commented Sep 2, 2020

Soon the Map Matching API will start returning a uuid field for all successful map match requests.

Once this field is returned for all profiles we should start using it in MapboxJava and remove the placeholder here

mapbox-java/services-matching/src/main/java/com/mapbox/api/matching/v5/MatchingResponseFactory.java

Line 73 in aa126fc

.requestUuid(PLACEHOLDER_UUID)

In the meantime, while we transition to including the uuid in all responses, we could consider adding optional parsing of the uuid field that falls back gracefully to the placeholder string. This could be useful for responses like NoMatch or NoRoute that don't return a uuid either.

/cc @Guardiola31337
@1ec5 1ec5 mentioned this issue Sep 9, 2020
Open
@1ec5
Copy link
Member

@1ec5 1ec5 commented Sep 9, 2020

mapbox/mapbox-directions-swift#457 tracks the equivalent change on iOS. That change can happen safely even if not all the profiles are returning UUIDs yet.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@1ec5 @danpaz