Skip to content

/ samples

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade provider shopper #521

Merged
merged 2 commits into from Aug 14, 2020
Merged

Upgrade provider shopper #521

merged 2 commits into from Aug 14, 2020

Conversation

@filiph
Copy link
Contributor

filiph commented Aug 13, 2020

No description provided.

@filiph
Upgrade provider shopper
Loading status checks…
501c6db
@johnpryan
johnpryan reviewed Aug 13, 2020
View changes
provider_shopper/analysis_options.yaml Outdated Show resolved Hide resolved
@johnpryan
Copy link
Contributor

johnpryan commented Aug 13, 2020

Just one question, otherwise LGTM
@filiph
Re-add linter rule
Loading status checks…
4b9615d
@filiph
Copy link
Contributor Author

filiph commented Aug 13, 2020

John, I can't merge until you give me approval in the github UI. Or, you can just merge yourself if that's easier.
@domesticmouse
domesticmouse approved these changes Aug 13, 2020
View changes
@filiph filiph merged commit c617da7 into flutter:master Aug 14, 2020
3 checks passed
3 checks passed
WIP Ready for review
Details
cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@filiph filiph deleted the filiph:provider-shopper-update branch Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnpryan johnpryan

@domesticmouse domesticmouse

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@filiph @johnpryan @domesticmouse
You can’t perform that action at this time.