Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup post v0.6.0 #70

Open
randy408 opened this issue May 9, 2020 · 0 comments
Open

Cleanup post v0.6.0 #70

randy408 opened this issue May 9, 2020 · 0 comments
Milestone

Comments

@randy408
Copy link
Owner

@randy408 randy408 commented May 9, 2020

To-do list for post-v0.6.0:

  • read_chunk_bytes() - simplify the crc_action check

  • Move the "discard trailing IDATs" stage to read_chunks()

  • Use an internal struct spng_text2 with just a pointer for the keyword to simplify parsing

  • Clean up spng_decode_scanline() (e.g. use a ihdr pointer)

  • Clean up flag handling in spng_decode_image()

  • Fix MSVC warnings

  • Move transparency testing for grayscale images out of the decoding loop, move it to trns_row()

  • Use get_sample() to iterate over 1/2/4-bit samples everywhere

  • Update check_png_keyword() before something bad happens

  • Use memcpy() less, omit where possible

@randy408 randy408 added this to the 0.7.0 milestone May 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.