Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUnify metrics for object stores #2478
Open
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We're missing any metrics for the azure client[1], and we have different metrics for S3[2] and GCS[3]. We should rationalise this into some sort of middleware for the object store interface that makes this more consistent.
[1] https://github.com/cortexproject/cortex/blob/master/pkg/chunk/azure/blob_storage_client.go
[2] https://github.com/cortexproject/cortex/blob/master/pkg/chunk/aws/s3_storage_client.go#L26
[3]
cortex/pkg/chunk/gcp/instrumentation.go
Line 53 in 996cb83