Skip to content

/ cloudinary_gem

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account Provisioning API #405

Open
wants to merge 8 commits into
base: master
from
Open

Account Provisioning API #405

wants to merge 8 commits into from

Conversation

@RTLcoil
Copy link
Collaborator

RTLcoil commented Jun 11, 2020

Added support for the account provisioning API.
RTLcoil added 5 commits Apr 12, 2020
@RTLcoil
Add Account Provisioning API implementation
Loading status checks…
6bfa191
@RTLcoil
Seperate `Cloudinary::Api` and `Cloudinary::AccountApi`
ffddf0b
@RTLcoil
Separate `Config` and `AccountConfig`
a2133d1
@RTLcoil
Rename `Cloudinary::Request` to `Cloudinary::BaseApi`
6fc7813
@RTLcoil
Edit Config tests
Loading status checks…
1c2d4f4
@amcaplan
amcaplan reviewed Jul 20, 2020
View changes
spec/spec_helper.rb Outdated Show resolved Hide resolved
spec/spec_helper.rb Outdated Show resolved Hide resolved
RTLcoil and others added 2 commits Jul 21, 2020
@RTLcoil @amcaplan
Replace `reduce` with `all` in spec_helper.rb
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a2bf463 
Co-authored-by: Ariel Caplan <amcaplan@users.noreply.github.com>
@RTLcoil @amcaplan
Replace `reduce` with `all` in spec_helper.rb
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9d67f06 
Co-authored-by: Ariel Caplan <amcaplan@users.noreply.github.com>
@RTLcoil
Copy link
Collaborator Author

RTLcoil commented Jul 21, 2020

@amcaplan Good idea. Suggested changes applied.

The CI tests fail now but it looks like an unrelated issue (Cloudinary::BaseApi::BadRequest: Cannot have more than 200 items).

I reran one of the older commits in Travis and it now breaks with the same error as the latest commits... this is a commit that passed successfully last time it ran.

FYI: @const-cloudinary
@RTLcoil RTLcoil requested a review from amcaplan Jul 21, 2020
@RTLcoil
Merge branch 'master' into feature/account-provisioning-api
Loading status checks…
593f90b
@RTLcoil
Copy link
Collaborator Author

RTLcoil commented Jul 22, 2020

@amcaplan
Merged from master. The tests pass now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amcaplan amcaplan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@RTLcoil @amcaplan
You can’t perform that action at this time.