DonJayamanne
Follow
Create your own GitHub profile
Sign up for your own profile on GitHub, the best place to host code, manage projects, and build software alongside 50 million developers.
Sign up
Pinned
2,241 contributions in the last year
Activity overview
Contributed to
microsoft/vscode-python,
DonJayamanne/pythonVSCode,
DonJayamanne/gitHistoryVSCode
and 5 other
repositories
Contribution activity
August 2020
Created a pull request in microsoft/vscode-python that received 5 comments
Refactor validation of kernels for VSC Notebooks
For #12189 Validation moved to when we run a cell. The kernel information returned to VSC from kernel provider now returns a stateless class No mo…
+616
−566
•
5
comments
- User KernelConnectionMetadata instead of KernelSpec + Interpreter
- Use KernelSelection instead of KernelSpecInterpreter
- Refactor KernelSelection type to include a `kind`
- Refactor cell execution using IKernel
- Add missing service Injection
- Revert "Notebook undo command is same as standard undo cmd (#13293)"
- Remove undo keybinding for notebook cells
- Ensure we do not switch kernel if already the same
- Notebook undo command is same as standard undo cmd
- Fixes to trusting native notebooks
- Support kernel selection in VSC Native Notebooks
- Dispose notebook on close of VSC Notebooks
- Rename get to getOrCreateModel
- WIP
- Remove work arounds for SaveAs of Native Notebooks
- User KernelConnectionMetadata instead of KernelSpec + Interpreter
- Use KernelSelection instead of KernelSpecInterpreter
- Refactor KernelSelection type to include a `kind`
- change language server from Jedi when creating native notebooks
- Support linting in native notebooks
- Refactor validation of kernels for VSC Notebooks
- Support launching with the same directory as a notebook
- Ensure we do not switch kernel if already the same
- August Release Update
- Pass cell metadata and cell id as metadata for execute_request
- Add gather status bar and update survey link
- Support kernel selection in VSC Native Notebooks
- Fix when clauses for new interactive cell shortcuts
- Issue 12414 python interactive cell editing shortcuts
- Nightly Tests Use Raw for default
Created an issue in microsoft/vscode-python that received 3 comments
Once raw notebook kernel is in broken state there's no way to recover unless you restart VS COde
VSC Native Notebooks + Raw Kernels
Somehow ended up in a situation where kernel was broken Error: Direct kernel connection broken
Restarting kerne…
3
comments
- Add keybindings for the new shortcuts added for interactive window
- In NativeNotebooks ensure we handle JupyterInvalidKernelError
- Use a single type to represent kernel connection information
- IPyWidgets does not work in remote sessions
- Nightly tests are broken due to missing injection
- Undo keybinding not working for notebook cells
- Variable viewer for Native Notebooks in activity bar (probably for Interactive window as well)
- Jupyter Activity bar
- Publish renderer extension and use it in Python extension for Native Notebooks
- Formatting of notebooks on save
- Run by line for native notebooks
- Gather for native notebooks
- Variable viewer for Native Notebooks
- SVG plot is displayed in favor of png plot
- Support formatting of all cells in notebook
- Support non Python kernels
- Executing command notebook.execute no longer works
- Kernel interrupt does not work for raw kernels
- Raw kernel interrutp does not seem to work at all on Mac
- Interrupting kernels does not work in VSC Native Notebooks
- Re-selecting the same kernel results in updates to notebook and switching of kernel
- Selecting a kernel does not prompt to install missing dependencies
- Native Notebook Kernel Issues
- Support non-raw kernels for VSC Native Notebooks
- Support connecting to remote kernels in VSC Notebooks
- Some issues not shown.