Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAllowing/disallowing subdomains #260
Open
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mmiszczyk commentedJan 14, 2020
Right now, AdvancedWebView will always trust not only a specified hostname but also all of its subdomains. It might be a better idea to make it configurable. In this patch, I've added the
setAllowSubdomains()method which decides whether we want the subdomains (by passingtrue) or the exact match on the hostname (by passingfalse). The default behavior is still to allow them for compatibility reasons (we don't want to break other people's code).