Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upEnable empty string to be set as missingValues in inferCellType #1192 #1208
Conversation
|
I need to look a bit more into this, because we were already setting it to InteredType.Null, and that should maybe be convertible to float. Can you push a unit test that reproes this fix then I'll see if I can fix it in a different way? |
|
@ovatsus I've added a test case. |
|
Thanks. I'll have a look to see if I can fix this by changing the merging of inferred types |
|
Close/open to re-run CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
zyzhu commentedSep 10, 2018
Attempt to fix #1192
Basically I changed the order of the if statement. It shall prioritize checking values set in
missingValueseven if they contains empty string.If empty string is not set in
missingValues, it will still fall back to checkString.IsNullOrWhiteSpace