I'm not sure that's worth it seeing how little code there's in the Confirmation controller.

Though we could probably move some of the methods of the ActivationMailer to a trait and re-use them in both places.

Tbh, this seems like a litle over-optimization. If we need to use that code again in a third place, then let's abstract it away. But for now, I think that might bring more confusion than justified

Honestly I don't agree. The code in the two files literally does the same exact thing, it's just arranged slightly differently. I think this brings more confusion because there are multiples places where the confirmation email can be sent out, with the same exact configuration.

A change in the confirmation email would require modifying the same (copy-pasted) code in two places, and I don't see how this could be considered good or make sense.

EDIT: moreover, in the case of password reset the code is already extracted in a command.