Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAllow Zoom Control & Location Button Customization #104
Conversation
Allowing the user to set not only `MyLocationEnabled` but also `ZoomControlsEnabled` and `MyLocationButtonEnabled`
| @@ -267,11 +264,7 @@ public void onMapClick(LatLng latLng) { | |||
| } | |||
|
|
|||
| @Override public void setMyLocationEnabled(boolean enabled) { | |||
| if (myLocationEnabled != enabled) { | |||
| if (RuntimePermissionUtils.checkLocationPermissions(getActivity(), this)) { | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
forrestbice
May 24, 2017
Author
Setting the myLocationEnabled flag here on NativeGoogleMapFragment doesn't require location permissions. If anything I think this check should live on within onLocationPermissionsGranted here https://github.com/forrestbice/AirMapView/blob/30b6f1e28836e6c9e737cd41548b64b761b23035/library/src/main/java/com/airbnb/android/airmapview/NativeGoogleMapFragment.java#L270 but since the caller is responsible for calling onLocationPermissionsGranted it seemed fine to offload the responsibility of the permission check as well. Note: The //noinspection MissingPermission lint flag was already present within onLocationPermissionsGranted
|
|
||
| @Override public void setMyLocationButtonEnabled(boolean enabled) { | ||
| // no-op | ||
| } |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
forrestbice
May 24, 2017
Author
I wasn't able to find it but I'm not super familiar with the JS library. Was looking here https://developers.google.com/maps/documentation/javascript/reference. Let me know if I should be looking elsewhere
|
@felipecsl if you're willing to look at my comment responses I'll go ahead and rebase this to resolve conflicts |
forrestbice commentedMay 23, 2017
Allowing the user to set not only
MyLocationEnabledbut alsoZoomControlsEnabledandMyLocationButtonEnabledAttempts to address #103