Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added leetcode problem 198 #571

Open
wants to merge 1 commit into
base: master
from

Conversation

@shoniavika
Copy link

shoniavika commented Jul 14, 2020

Description of Change

References

Checklist

  • [x ] Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

@shoniavika
Copy link
Author

shoniavika commented Jul 14, 2020

Hi, I want to add multiple problems to leetcode directory. First I tried adding all three (I'm adding 3) simultaneously, but Code Formatter fails. Is there any way around it?

@kvedala
Copy link
Collaborator

kvedala commented Jul 14, 2020

Hi Thank you for your contributions.

The existing leetcode folder is quite old and hence you will notice that the folder does not conform to the standards of the rest of the repo in terms of:

  1. no documentations in the files - the repo is meant for educational purposes so that people can read and learn from the code.
  2. code does not generate an executable because of lack of main() function.
  3. codes do not implement self-tests to verify the execution is correct for various test cases

We can create a temporary work-around but that would make this folder an odd-one out and difficult to support and maintain. The correct way to go about this would be to update the existing folder with respect to the above mentioned points and we would need help on it. This could also be a great opportunity to learn from the code while documenting them and making them execute. Would you be able to join in on the efforts? Thanks

@shoniavika
Copy link
Author

shoniavika commented Jul 14, 2020

Sure, no problem! Just to be clear, the goal is to update leetcode directory, so each file contains 3 aspects you mentioned above?

@kvedala
Copy link
Collaborator

kvedala commented Jul 14, 2020

Sure, no problem! Just to be clear, the goal is to update leetcode directory, so each file contains 3 aspects you mentioned above?

Yes, please refer to other files in the repo like this one and this one that have good documentation and self-tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.