Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upmake iterator python3 compatible #1007
Open
Conversation
|
Thanks a lot for your contribution. I have a left a comment to see if this could be a non-breaking change for safety reasons. GitPython seems to be used by 15.4k projects, and there might be one of them who used Thanks for your consideration. |
| @@ -498,7 +498,7 @@ def readlines(self, size=-1): | |||
| def __iter__(self): | |||
| return self | |||
|
|
|||
| def next(self): | |||
| def __next__(self): | |||
Byron
Apr 22, 2020
Member
Would this be a breaking change if people used next directly?
I am wondering if the old method name should be retained for safety, like so:
def next(self):
return self.__next__()
Would this be a breaking change if people used next directly?
I am wondering if the old method name should be retained for safety, like so:
def next(self):
return self.__next__()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
No description provided.