Skip to content

/ GitPython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handling of relative submodule paths #875

Open
wants to merge 1 commit into
base: master
from
Open

Handling of relative submodule paths #875

wants to merge 1 commit into from

Conversation

@PhilLab
Copy link

@PhilLab PhilLab commented May 19, 2019 •
edited

This MR is merely a start for a discussion about how to solve #730

Is incomplete, I still get errors
@PhilLab
Relative URLs for submodules
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
04c9924 
Closes #730
@codecov-io
Copy link

@codecov-io codecov-io commented May 19, 2019 •
edited

Codecov Report

Merging #875 into master will decrease coverage by <.01%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #875      +/-   ##
==========================================
- Coverage   94.79%   94.78%   -0.01%     
==========================================
  Files          59       59              
  Lines        9607     9611       +4     
==========================================
+ Hits         9107     9110       +3     
- Misses        500      501       +1
Impacted Files Coverage Δ
git/objects/submodule/root.py 91.91% <80%> (-0.52%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11fd713...04c9924. Read the comment docs.
@Byron Byron added the acknowledged label Jul 20, 2019
@Byron
Copy link
Member

@Byron Byron commented Sep 28, 2019

Thanks a lot for your initiative!
Would it help to add a test that represents the case to be fixed?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
acknowledged waiting for feedback
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@PhilLab @codecov-io @Byron
You can’t perform that action at this time.