fetch --prune resulting in a dangling HEAD #962

njalerikson · 2019-11-25T17:35:42Z

Fetch prune fails if HEAD ends up dangling. Given that the message appears more warning like in nature, as opposed to an error, should GitPython handle this/ignore it?

To reproduce with pure git:

git clone <some-repo>
# delete master branch from remote
git fetch --prune -v origin

The fetch returns something like this:

From ...
 * [new branch]      production -> origin/production
 x [deleted]         (none)     -> origin/master
   (refs/remotes/origin/HEAD has become dangling)

GitPython crashes here as it parses the FetchInfo:

GitPython/git/remote.py

Lines 290 to 292 in 85cf7e8

    
           match = cls._re_fetch_result.match(line) 
        
           if match is None: 
        
               raise ValueError("Failed to parse line: %r" % line)

Should dangling just be ignored in general or should there be an option to ignore_dangling?

Byron · 2019-12-08T11:52:18Z

Thanks for making the issue so easy to follow!
Currently GitPython seems to be taking the stance of rejecting anything it does’t know, which seems like a dangerous choice when being dependent on another ever changing command-line program.

In order not to break code which might rely on this particular behaviour though, I would certainly prefer adding an option like ignore_dangling and default it to false even though defaulting it to true would probably be easier to use for most.

Byron added acknowledged help wanted labels Dec 8, 2019

gitpython-developers / GitPython

fetch --prune resulting in a dangling HEAD #962

fetch --prune resulting in a dangling HEAD #962

njalerikson commented Nov 25, 2019

Byron commented Dec 8, 2019

gitpython-developers / GitPython

Join GitHub today

fetch --prune resulting in a dangling HEAD #962

fetch --prune resulting in a dangling HEAD #962

Comments

njalerikson commented Nov 25, 2019

Byron commented Dec 8, 2019