Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] Create_submodule fails due to use of hidden files #516

Closed
matthewwardrop opened this issue Sep 22, 2016 · 4 comments
Closed

[Windows] Create_submodule fails due to use of hidden files #516

matthewwardrop opened this issue Sep 22, 2016 · 4 comments

Comments

@matthewwardrop
Copy link

@matthewwardrop matthewwardrop commented Sep 22, 2016

On Windows, the .git files are given the hidden attribute. If a file is marked as hidden, it cannot be written to using the standard Python open(..., 'w') command. This is because the underlying win32 api errors unless the attributes of the open command match the attributes of the file, and this is not exposed in the Python API

For example, consider the following snippet:

import git
r = git.Repo('test')
r.create_submodule(name='testing', path='testing', url='https://github.com/matthewwardrop/python-parampy')

On Unix, this works fine. In Windows, however, it will crash with the following stack trace:

Traceback (most recent call last):
  ...
  File "c:\program files\python35\lib\site-packages\git\repo\base.py", line 306, in create_submodule
    return Submodule.add(self, *args, **kwargs)
  File "c:\program files\python35\lib\site-packages\git\objects\submodule\base.py", line 389, in add
    mrepo = cls._clone_repo(repo, url, path, name, **kwargs)
  File "c:\program files\python35\lib\site-packages\git\objects\submodule\base.py", line 253, in _clone_repo
    cls._write_git_file_and_module_config(module_checkout_path, module_abspath)
  File "c:\program files\python35\lib\site-packages\git\objects\submodule\base.py", line 292, in _write_git_file_and_mod
ule_config
    fp = open(git_file, 'wb')
PermissionError: [Errno 13] Permission denied: 'C:\\Users\\matthewwardrop\\test\\testing\\.git'

There's probably a workaround using the raw git commands, but it would be nice to have this cleaned up.

@Byron Byron added the acknowledged label Sep 25, 2016
@Byron
Copy link
Member

@Byron Byron commented Sep 25, 2016

Thanks for letting me know. If you can come up with a solution that works for you, I would be very happy about a PR. Windows is not a platform I can test on, and am therefore dependent on contributions in that realm.

@ankostis
Copy link
Contributor

@ankostis ankostis commented Oct 1, 2016

@matthewwardrop this must have been fixed by #519 (b8b025f) where the file gets deleted before overwritting it.
I had the same problem, but I couldn't understand why this was happening; thanks for the tip!

Anyway, please check if it is ok, before closing the issue.

@Byron
Copy link
Member

@Byron Byron commented Mar 8, 2017

I am closing this issue as it had no interaction for more than 3 months. Please feel free to comment in case you need it to be reopened.

@Byron Byron closed this Mar 8, 2017
@ankostis ankostis added the tag.Windows label Mar 8, 2017
@matthewwardrop
Copy link
Author

@matthewwardrop matthewwardrop commented Mar 10, 2017

@Byron @ankostis Thanks for fixing this. Sorry for the huge delay. I don't often use Windows, so I guess I never got around to checking this. Given that things seem to work for you in appveyor, and people have not been reporting bugs against my project (the knowledge repo), it looks like these issues have been fixed. I really appreciate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.