Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement is_ancestor #322
Merged
Conversation
|
Thank you ! Have you managed to get nosetest to work for you ? It should be easy to add a test to verify that
|
|
I am writing a test as we speak |
bwrsandman
force-pushed the
bwrsandman:is_ancestor
branch
2 times, most recently
from
d402f7b
to
acc559f
Wrap `git merge-base --is-ancestor` into its own function because it acts as a boolean check unlike base `git merge-base call`
|
Test done. Sorry I have no video of the coding ;) |
|
Thank you ! Looks great, even without the video :). Closes #321 |
Byron
merged commit 1883eb9
into
gitpython-developers:master
1 check passed
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Wrap
git merge-base --is-ancestorinto its own function because it actsas a boolean check unlike base
git merge-base call