Skip to content

/ GitPython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read conditional include #1054

Merged
merged 12 commits into from Sep 4, 2020
Merged

Read conditional include #1054

merged 12 commits into from Sep 4, 2020

Conversation

@buddly27
Copy link
Contributor

@buddly27 buddly27 commented Sep 3, 2020

Closing #1053

Read conditional includes as defined in:
https://git-scm.com/docs/git-config#_conditional_includes
buddly27 added 9 commits Sep 2, 2020
@buddly27
Add Regex to match content of "includeIf" section
c16f584
@buddly27
Update check method to find all includes
9766832
@buddly27
Add reference to repository to config.
d5262ac 
This is necessary when working with conditional include
sections as it requires the git directory or active branch name.

https://git-scm.com/docs/git-config#_conditional_includes
@buddly27
Add method to retrieve all possible paths to include
8e263b8
@buddly27
Fix logic to properly compare glob pattern to value
f37011d
@buddly27
Add unit tests
3dcb520
@buddly27
Update AUTHOR to respect to contributing guidelines.
16d3ebf
@buddly27
Add missing rules to match hierarchy path
Loading status checks…
c3fc83f
@buddly27
Add missing blank line
Loading status checks…
c3eae2c
@buddly27 buddly27 mentioned this pull request Sep 3, 2020
Open
@Byron Byron added this to the v3.1.8 - Bugfixes milestone Sep 3, 2020
@Byron
Byron requested changes Sep 3, 2020
View changes
Copy link
Member

@Byron Byron left a comment

Thanks a lot for tackling this issue. It's a fantastic display on how tests can be written, and I hope future PRs will have more of that.

I found two spots to look at or discuss, along with a lot of praise in the other comments.

Please let me know what you think.
test/test_config.py Show resolved Hide resolved
test/test_config.py Show resolved Hide resolved
AUTHORS Outdated Show resolved Hide resolved
git/config.py Outdated Show resolved Hide resolved
git/config.py Outdated Show resolved Hide resolved
git/config.py Outdated Show resolved Hide resolved
buddly27 added 3 commits Sep 3, 2020
@buddly27
Remove name as not necessary to track down authors.
2c4dec4
@buddly27
Reformat code to remove unnecessary indentation
3787f62
@buddly27
Ensure that detached HEAD does not raise when comparing branch name.
Loading status checks…
5b88532
@Byron Byron merged commit 94bbe51 into gitpython-developers:master Sep 4, 2020
4 checks passed
4 checks passed
build (3.5)
Details
build (3.6)
Details
build (3.7)
Details
build (3.8)
Details
@Byron
Copy link
Member

@Byron Byron commented Sep 4, 2020

Fantastic, thanks a lot. I am going to create a new release soon!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Byron Byron

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.1.8 - Bugfixes
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@buddly27 @Byron
You can’t perform that action at this time.