Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upcreate_submodule fails on existing submodule #678
Closed
Comments
This was referenced Oct 2, 2017
Merged
Am able to solve this issue with the patch in PR ( #679 ). However I'm unclear as to whether that is how we should solve it or not. |
Just as clarification, this is basically showing that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Based on the docs for
create_submodule
, it sounds like it proceeds throughSubmodule.add
. According to the docs forSubmodule.add
, it sounds likeadd
should still work fine if the submodule already exists. However that does not appear to be the case. Have included an example of the issue experienced below along with details about how to create an environment where this issue can be reproduced.Example:
Environment (with
conda
):FWIW relevant entry in
.gitmodules
: