Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix GitError being raised in initial `import git` #658
Conversation
This catches any raise of one of the custom exceptions defined in `git.exc` during the imports in the dunder init, and raises an `ImportError` in those cases.
|
Thanks a ton for your contribution, and my apologies for getting to this PR that late! This looks great! |
terminalmage
added a commit
to terminalmage/GitPython
that referenced
this pull request
Jun 1, 2018
This is related to my fix in gitpython-developers#658. Apparently, MacOS adds a git executable that is just a stub which displays an error. This gets past the try/except I added in gitpython-developers#658, and allows all of the GitPython components to be imported, but since the executable is not *actually* git, it results in an exception when ``refresh()`` attemepts to run a ``git version``.
This was referenced Jun 1, 2018
Byron
added a commit
that referenced
this pull request
Jun 5, 2018
This is related to my fix in #658. Apparently, MacOS adds a git executable that is just a stub which displays an error. This gets past the try/except I added in #658, and allows all of the GitPython components to be imported, but since the executable is not *actually* git, it results in an exception when ``refresh()`` attemepts to run a ``git version``.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This catches any raise of one of the custom exceptions defined in
git.excduring the imports in the dunder init, and raises anImportErrorin those cases.This is my (perhaps naïve) attempt to fix #657.