Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find paths ignored in .gitignore #1063

Merged
merged 3 commits into from Sep 29, 2020

Conversation

@saroad2
Copy link
Contributor

@saroad2 saroad2 commented Sep 28, 2020

Using git check-ignore in order to find whether paths are ignored or not in .gitignore

Copy link
Member

@Byron Byron left a comment

Thanks a lot for you contribution!

The merge is just two minor changes away, with the option for a bigger change for correctness. The latter won't block a merge though in case there is no time for that.

git/repo/base.py Show resolved Hide resolved
git/repo/base.py Outdated Show resolved Hide resolved
git/repo/base.py Outdated Show resolved Hide resolved
Copy link
Member

@Byron Byron left a comment

Thanks for the improvements! I think that leaves just one tiny thing before it can be merged.
Thanks for bearing with me.

git/repo/base.py Outdated Show resolved Hide resolved
@Byron Byron added this to the v3.1.9 - Bugfixes milestone Sep 29, 2020
@Byron Byron merged commit 60acfa5 into gitpython-developers:master Sep 29, 2020
4 checks passed
4 checks passed
build (3.5)
Details
build (3.6)
Details
build (3.7)
Details
build (3.8)
Details
@saroad2 saroad2 deleted the saroad2:find_ignored_path branch Sep 29, 2020
@Byron
Copy link
Member

@Byron Byron commented Sep 29, 2020

Great, thanks again!

@saroad2
Copy link
Contributor Author

@saroad2 saroad2 commented Sep 29, 2020

Thanks a lot for the merge!

When are you planning on releasing a new version to PyPi? I would like to use this new ability in one of my projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.