Skip to content

/ GitPython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't install unittest code by default #1027

Closed
priv-kweihmann opened this issue Jul 7, 2020 · 2 comments
Closed

Don't install unittest code by default #1027

priv-kweihmann opened this issue Jul 7, 2020 · 2 comments
Labels
acknowledged help wanted

Comments

@priv-kweihmann
Copy link
Contributor

@priv-kweihmann priv-kweihmann commented Jul 7, 2020

When doing python3 setup.py install on a local checkout of the code, files from git/test will be installed into the standard site-packages directory.
This mean that theoretically even the requirements from test-requirements.txt are mandatory for the base package and secondly it isn't necessary as the chances that an user is actually using the test code are pretty low.
So overall it doesn't make much sense to me.

Is there any way to avoid having the test files installed via setuptools?
@Byron
Copy link
Member

@Byron Byron commented Jul 7, 2020

Thanks for bringing this up! I agree with the sentiment and believe it would be preferable not to package and install test files.

Maybe these can be excluded during packaging? Help is greatly appreciated, as I only remember the incredible pain that setup.py inflicted on me.
@priv-kweihmann
Copy link
Contributor Author

@priv-kweihmann priv-kweihmann commented Jul 8, 2020

I'm pretty sure that this is possible - I think it requires just some magic in setup.py and the MANIFEST.in.
BTW I think the tests itself should be in the root directory rather than a subdir of the module itself - is there a reason for them being placed where they are right now?

I'll see if I could come up with a PR for it
@priv-kweihmann priv-kweihmann mentioned this issue Jul 10, 2020
Merged
@Byron Byron closed this in #1028 Jul 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
acknowledged help wanted
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

move test and avoid packaging them
2 participants
@Byron @priv-kweihmann
You can’t perform that action at this time.