Skip to content

/ GitPython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update versions #706

Closed
wants to merge 3 commits into from
Closed

Update versions #706

wants to merge 3 commits into from

Conversation

@hugovk
Copy link
Contributor

@hugovk hugovk commented Dec 4, 2017 •
edited

Includes #705 so Travis CI can pass.

Specify Python 3.6 support in README and add python_requires so pip can install the correct distribution for the user's Python version.

Also remove some long-redundant Python 2.4 code.
hugovk added 2 commits Dec 4, 2017
@hugovk
Fix flake8
Loading status checks…
d92af06
@hugovk
Specify Python 3.6 support
0b8ada6
@codecov-io
Copy link

@codecov-io codecov-io commented Dec 5, 2017

Codecov Report

Merging #706 into master will increase coverage by 1%.
The diff coverage is 90.24%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master     #706    +/-   ##
========================================
+ Coverage   92.83%   93.84%    +1%     
========================================
  Files          61       60     -1     
  Lines       10152     9339   -813     
========================================
- Hits         9425     8764   -661     
+ Misses        727      575   -152
Impacted Files Coverage Δ
git/test/test_submodule.py 97.52% <ø> (ø) ⬆️
git/test/lib/helper.py 87.79% <0%> (ø) ⬆️
git/refs/log.py 93.84% <0%> (ø) ⬆️
git/test/test_commit.py 100% <100%> (ø) ⬆️
git/exc.py 96.42% <100%> (ø) ⬆️
git/diff.py 99.11% <100%> (ø) ⬆️
git/compat.py 64.81% <100%> (ø) ⬆️
git/test/test_util.py 88.23% <100%> (ø) ⬆️
git/repo/base.py 95.47% <66.66%> (+0.18%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a96030...ceacc6f. Read the comment docs.
@hugovk
Remove redundant Python 2.4 code
Loading status checks…
ceacc6f
cwonrails added a commit to cwonrails/GitPython that referenced this pull request Dec 7, 2017
@cwonrails
Merge upstream gitpython-developers#705 & gitpython-developers#706 PRs
Verified
This commit was signed with a verified signature.
cwonrails Chris Watson
GPG key ID: 1C78AA0DB8AB0F86 Learn about signing commits
936a03d 
* github.com:gitpython-developers/GitPython:
  Remove redundant Python 2.4 code
  Specify Python 3.6 support
  Fix flake8
@Byron
Copy link
Member

@Byron Byron commented Dec 11, 2017

Thanks a lot for your contribution! I am closing this PR as I found it easiest to just cherry-pick the non-conflicting commits. The flake-8 fixes were merged in earlier.
@Byron Byron closed this Dec 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@hugovk @codecov-io @Byron
You can’t perform that action at this time.