Configparser does not respect order of config files with includes #627

DanielSiepmann · 2017-05-13T17:03:16Z

When you have an include statement in the user .gitconfig there content will take precedence over the local .git/config of the repository.

E.g. the following code:
entry = repo.config_reader().get_value('gitlab', 'url')

With the following config setup:

~/.gitconfig:

[include]
    path = ~/.gitconfig-local
[gitlab]
    url = url1

~/.gitconfig-local:

[gitlab]
    url = url2

.git/config:

[gitlab]
    url = url3

Will return url2 I would expect to receive url3 instead as local config should take precedence as the include was in a more global config.

Looks like the issue resides inside the read function e.g.

GitPython/git/config.py

Line 427 in c823d48

files_to_read.append(include_path)

will just add the includes to the list, which is just wrong, as they should be read instantly to overwrite just the already known configs.

As the function is just to big, I'm not able to provide a fix.

Versions in use:

>>> import git; git.__version__
'2.1.3'

python --version
Python 2.7.13

Byron · 2017-05-28T18:15:06Z

@DanielSiepmann Thanks for the detailed description, and for the fix! Please have a look at my review - I hope to be able to merge the fix soon and create a new release accordingly.

DanielSiepmann mentioned this issue May 14, 2017

BUGFIX: 627 fix include order #628

Closed

Byron added the acknowledged label May 28, 2017

yarikoptic mentioned this issue Nov 27, 2017

BF: process included files before the rest #700

Merged

3 of 3 tasks complete

Byron closed this in #700 Dec 11, 2017

gitpython-developers / GitPython

Configparser does not respect order of config files with includes #627

Configparser does not respect order of config files with includes #627

DanielSiepmann commented May 13, 2017 •

edited

Byron commented May 28, 2017

gitpython-developers / GitPython

Join GitHub today

Configparser does not respect order of config files with includes #627

Configparser does not respect order of config files with includes #627

Comments

DanielSiepmann commented May 13, 2017 • edited

Byron commented May 28, 2017

DanielSiepmann commented May 13, 2017 •

edited