Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding setup for git executable #640

Merged

Commits on Jul 9, 2017

  1. Preliminary implementation of setup/refresh functions

    Added one function (setup) and an alias (refresh simply calls setup).
    These functions give the developer one more way to configure the git
    executable path. This also allows the user to interactively adjust the
    git executable configured during runtime as these functions dynamically
    update the executable path for the entire git module.
    njalerikson committed Jul 9, 2017
  2. Moved setup function into top level __init__

    Discovered that the remote module also relies on the git executable as
    such it also needs to be “refreshed” anytime the git executable is
    updated or changed. This was best solved by moving the setup function
    into the top level __init__ where the setup simply calls
    git.cmd.Git.refresh and git.remote.FetchInfo.refresh.
    njalerikson committed Jul 9, 2017
  3. Renamed refresh to setup and removed alias function & added unittest

    Renamed to simplify and avoid issue with nose tests trying to use
    `setup` as a setup for testing. Unittest implements basic test for
    refreshing with a bad git path versus a good git path.
    njalerikson committed Jul 9, 2017
  4. Modified AUTHORS file

    Added my name to list.
    njalerikson committed Jul 9, 2017
  5. Added ability to silence initial warning

    Added the ability to silence the first refresh warning upon import by
    setting an environment variable.
    njalerikson committed Jul 9, 2017

Commits on Jul 13, 2017

  1. Expanded ability of import

    Renamed GIT_PYTHON_NOWARN to GIT_PYTHON_INITERR and added values for
    quiet import, warning import, and raise import. These respectively mean
    that no message or error is printed if git is non-existent, a plain
    warning is printed but the import succeeds, and an ImportError
    exception is raised.
    njalerikson committed Jul 13, 2017
  2. Removed remaining references to git.setup function

    Removed few remaining references to git.setup function (as it was
    renamed to refresh).
    njalerikson committed Jul 13, 2017
  3. Renamed GIT_PYTHON_INITERR to GIT_PYTHON_REFRESH

    Renamed and cleaned up variable names.
    njalerikson committed Jul 13, 2017

Commits on Jul 25, 2017

  1. Minor additional cleanup

    Added additional information in the import warning/error that tells the
    user how to silence the warning/error. Also added a GIT_OK variable
    that allows for a quick check whether the refresh has succeeded instead
    of needing to test an actual git command.
    njalerikson committed Jul 25, 2017

Commits on Jul 26, 2017

  1. Minor bug fixes

    Added tilde expansion as part of the refresh function. Added python
    version check such that we properly capture PermissionError in Python
    >=3 and OSError in Python <3.
    njalerikson committed Jul 26, 2017

Commits on Sep 28, 2017

  1. Merge branch 'master' into adding_setup_for_git_executable

    Byron committed Sep 28, 2017
You can’t perform that action at this time.