Skip to content

/ GitPython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMD windows created for Windows GUI python programs #495

Closed
barry-scott opened this issue Jul 29, 2016 · 3 comments
Closed

CMD windows created for Windows GUI python programs #495

barry-scott opened this issue Jul 29, 2016 · 3 comments
Labels
acknowledged

Comments

@barry-scott
Copy link
Contributor

@barry-scott barry-scott commented Jul 29, 2016

Prevent CMD windows being shown when starting git in a subprocess.

This fixes a UI problem with using GitPython from a GUI python probgram.
Each repo that is opened creates a git cat-file processs and that provess will create
a console window with out this change.

patch.txt
@barry-scott barry-scott changed the title CMS windows created for Windows GUI python programs CMD windows created for Windows GUI python programs Jul 29, 2016
@Byron
Copy link
Member

@Byron Byron commented Jul 30, 2016

Please note that the patch referred to by the OP is already part of #469. The issue can be closed when merged.
@Byron Byron added the acknowledged label Jul 30, 2016
@barry-scott
Copy link
Contributor Author

@barry-scott barry-scott commented Aug 1, 2016

Oh I get it because I push master you see in the PR. I did not expect that.
@barry-scott
Copy link
Contributor Author

@barry-scott barry-scott commented Aug 2, 2016

Fixed by PR #469.
@barry-scott barry-scott closed this Aug 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
acknowledged
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@Byron @barry-scott
You can’t perform that action at this time.