Skip to content

/ GitPython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Malformatted options #340

Closed
StyXman opened this issue Aug 19, 2015 · 2 comments
Closed

Malformatted options #340

StyXman opened this issue Aug 19, 2015 · 2 comments
Labels
acknowledged
Milestone
v1.0.2 - Fixes

Comments

@StyXman
Copy link
Contributor

@StyXman StyXman commented Aug 19, 2015

I'm using git.Git a lot for calling low level git commands; for instance, git commit-tree. In particular, I'm trying to use the -m option, but Git.transform_kwargs() converts m='foo' into -mfoo, which git rejects:

git commit-tree -mfoo e53dc311b7e3ac674f3a6548a22113307a6af3ef -> 128; stdout: '<OUTPUT_STREAM>'; stderr: 'fatal: Not a valid object name -mfoo'

I'm not sure if the current formatting is like so for any particular reason, and I found about the split_single_char_options argument, but there seems to be no way to control that via the API.
@Byron Byron added the acknowledged label Aug 19, 2015
@Byron Byron added this to the v1.0.2 - Fixes milestone Aug 19, 2015
@Byron
Copy link
Member

@Byron Byron commented Aug 19, 2015

I totally agree and am not sure myself why it is implemented in that particular way. Changing the default might be a suitable fix (e.g. setting split_single_char_options could be turned on by default).

Would you like to submit a PR for this ? Chances are everything will just work fine after that, while fixing the issue.
@StyXman
Copy link
Contributor Author

@StyXman StyXman commented Aug 19, 2015

Well, the unit tests don't pass in my machine (tests py2.7 [FAILED (errors=10, failures=3)] and 3.4 [FAILED (errors=10, failures=2)]), but the fix is simple enough and travis gives OK. Maybe you can try it on your side? See #341.
@StyXman StyXman mentioned this issue Aug 19, 2015
Merged
@Byron Byron closed this Aug 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
acknowledged
Projects
None yet
Milestone
v1.0.2 - Fixes
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@Byron @StyXman
You can’t perform that action at this time.