Skip to content

/ GitPython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not all of diff types documented and used in iter_change_type #964

Open
worldmind opened this issue Dec 6, 2019 · 2 comments
Open

Not all of diff types documented and used in iter_change_type #964

worldmind opened this issue Dec 6, 2019 · 2 comments
Labels
acknowledged help wanted

Comments

@worldmind
Copy link

@worldmind worldmind commented Dec 6, 2019

Here, in comments five types described (not sure that this comment needed because same info in docstring), but below six types in change_type, in docstring here 5 types and here 5 types processed.
Looks like type 'C' not described, but processed and 'T' described but not processed.
@Byron
Copy link
Member

@Byron Byron commented Dec 8, 2019

Absolutely right, thanks a lot for taking the time to point this out. It would be great to see a PR to improve this, such that

  • the comment is deleted
  • the doc-string is updated to include the ‘C’ change type
  • the processing for the ‘T’ change type is added
@worldmind
Copy link
Author

@worldmind worldmind commented Dec 8, 2019

I will be glad to prepare a PR, but I am even can't understand what is going on in code because on first look it can be replace by such code:

for diff in self:
    yield diff

but may be I miss something and some diffs must be excluded from iteration?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
acknowledged help wanted
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@Byron @worldmind
You can’t perform that action at this time.