Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign up[RFC/WIP] move tests and avoid packaging them #1031
Merged
Conversation
This should ensure that tests are NOT packaged into release package by setuptools, as tests are development only + fixtures after moving Signed-off-by: Konrad Weihmann <[email protected]>
by using exclude feature of find_packages. py_modules are determined by new function, which recursively scans the base dir but omits the external modules. Plus remove now obselete package_data setting Signed-off-by: Konrad Weihmann <[email protected]>
and remove all previously used test related settings Signed-off-by: Konrad Weihmann <[email protected]>
Signed-off-by: Konrad Weihmann <[email protected]>
which installs the current codebase in a venv and runs 'import git' to test if codebase can be installed properly. This adds virtualenv to the test requirements Signed-off-by: Konrad Weihmann <[email protected]>
priv-kweihmann
changed the title
|
Thanks a lot for giving it another go, and for 'the test' which will probably save many people a lot of time in future by catching bad releases before they happen. I will cut a new release, fingers crossed! PS: This PR is probably worth ~15GB in saved transfer volume per month if these stats can be trusted - amazing! |
This was referenced Jul 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This is the followup to #1028.
Move test files out of git module and into the root dir.
This enables it to ignore them while setuptools packaging and is resulting in a way smaller release package.
additionally a new test is added, which tests package installation, to avoid ModuleNotFound errors (e.g. #1030) in future
Please review and test locally if possible - that's why I marked it as RFC/WIP for now