Skip to content

/ GitPython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#993 fix: wrong refs 'HEAD' exception #999

Merged
merged 1 commit into from Mar 21, 2020
Merged

#993 fix: wrong refs 'HEAD' exception #999

merged 1 commit into from Mar 21, 2020

Conversation

@dongs0104
Copy link
Contributor

@dongs0104 dongs0104 commented Mar 18, 2020 •
edited

When git HEAD refs is broken, it raise BadName exception.
so submodules logic which is using a rev_parse function to HEAD get Exception, so handle BadName to return empty list

b303cb0

GitPython/git/diff.py

Lines 281 to 287 in b303cb0

# Determine whether this diff references a submodule, if it does then
# we need to overwrite "repo" to the corresponding submodule's repo instead
if repo and a_rawpath:
for submodule in repo.submodules:
if submodule.path == a_rawpath.decode("utf-8"):
repo = submodule.module()
break

@dongs0104
fix: wrong refs 'HEAD' exception
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
dbc8de7
@dongs0104 dongs0104 mentioned this pull request Mar 18, 2020
Open
@Byron
Copy link
Member

@Byron Byron commented Mar 21, 2020

Thanks a lot for your contribution :)! It's much appreciated.

CC: #993 , where diff is broken due to a very similar issue.
@Byron Byron added this to the v3.1.1 - Bugfixes milestone Mar 21, 2020
@Byron Byron merged commit 5db2e0c into gitpython-developers:master Mar 21, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.1.1 - Bugfixes
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@dongs0104 @Byron
You can’t perform that action at this time.