Skip to content

/ GitPython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ModuleNotFoundError: No module named 'git.objects' #1030

Closed
HappyEinara opened this issue Jul 12, 2020 · 6 comments
Closed

ModuleNotFoundError: No module named 'git.objects' #1030

HappyEinara opened this issue Jul 12, 2020 · 6 comments
Labels
acknowledged

Comments

@HappyEinara
Copy link

@HappyEinara HappyEinara commented Jul 12, 2020

The release just now might have broken something.

Steps to reproduce:

  • Fresh venv, python3.8
  • pip install --upgrade gitpython
  • python
    then:
>>> import git
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/vagrant/.virtualenvs/tmpgit/lib/python3.8/site-packages/git/__init__.py", line 41, in <module>
    from git.objects import *               # @NoMove @IgnorePep8
ModuleNotFoundError: No module named 'git.objects'
@michalb-dsg
Copy link

@michalb-dsg michalb-dsg commented Jul 12, 2020

I got the same error
@Byron
Copy link
Member

@Byron Byron commented Jul 12, 2020

Definitely related to the changes coming from #1028 , could @priv-kweihmann have a look?
The tar archive definitely has the 'git/objects' directory, so I am a bit surprised it doesn't get installed.

As immediate action I am rolling the change back.
@p0tr3c
Copy link

@p0tr3c p0tr3c commented Jul 12, 2020

same here :-(
Byron added a commit that referenced this issue Jul 12, 2020
@Byron
Revert moving tests out of 'git' folder, related to #1030
Unverified
This user has not uploaded their public key yet.
GPG key ID: EE029D1E5EB40300 Learn about signing commits
d5f0d48
@Byron
Copy link
Member

@Byron Byron commented Jul 12, 2020

v3.1.5 was released with the PR in question reverted. My apologies for the inconvenience!

I hope there is a way to test the usability of releases prior to making them, somehow, it's not the first time a release breaks even though it looks alright. Maybe something like this can be contributed. Personally I do consider setup.py and friends black magic that I cannot touch or tame, and must be relying on contributions to improve the situation. Thanks for your understanding and support.
@Byron Byron added the acknowledged label Jul 12, 2020
@priv-kweihmann
Copy link
Contributor

@priv-kweihmann priv-kweihmann commented Jul 12, 2020 •
edited

Definitely related to the changes coming from #1028 , could @priv-kweihmann have a look?
The tar archive definitely has the 'git/objects' directory, so I am a bit surprised it doesn't get installed.

As immediate action I am rolling the change back.

I will - as this could take some time, it's really better to rollback for now. Will try to include some tests so that this won't happen again
@priv-kweihmann priv-kweihmann mentioned this issue Jul 12, 2020
Merged
@Byron
Copy link
Member

@Byron Byron commented Jul 13, 2020

I am closing this issue as it was fixed with v3.1.5, which was released about 30 minutes after v3.1.4.
With the PR above we have brought back the reduced package size in v3.1.6, which is likely to be working as we are now testing for git being importable after having been installed (from source).
@Byron Byron closed this Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
acknowledged
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
@Byron @p0tr3c @HappyEinara @priv-kweihmann @michalb-dsg
You can’t perform that action at this time.