Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a SWIFT_FREESTANDING_MODULE_NAME CMake option #34018

Merged
merged 1 commit into from Sep 22, 2020

Conversation

@kubamracek
Copy link
Contributor

@kubamracek kubamracek commented Sep 21, 2020

Add a SWIFT_FREESTANDING_MODULE_NAME CMake option to be able to select the last part of a .swiftmodule filename when building the "freestanding" variant of stdlib. This is needed to bringup building and testing infrastructure for "freestanding".

Eventually, these flags (SWIFT_FREESTANDING_MODULE_NAME, SWIFT_FREESTANDING_TRIPLE_NAME) should go away, but that can only happen once Clang and Swift actually accept "freestanding" or "none" as a target triple.

@kubamracek kubamracek requested review from compnerd and gottesmm Sep 21, 2020
@kubamracek
Copy link
Contributor Author

@kubamracek kubamracek commented Sep 21, 2020

@swift-ci please test

@kubamracek kubamracek merged commit 41f91d5 into apple:master Sep 22, 2020
5 checks passed
5 checks passed
Swift Test Linux Platform
Details
Swift Test Linux Platform (smoke test)
Details
Swift Test OS X Platform
Details
Swift Test OS X Platform (smoke test)
Details
Swift Test Windows Platform Build finished. No test results found.
Details
@kubamracek kubamracek deleted the kubamracek:freestanding-module-name branch Sep 22, 2020
ainu-bot added a commit to google/swift that referenced this pull request Sep 22, 2020
* 'master' of github.com:apple/swift:
  Add a SWIFT_FREESTANDING_MODULE_NAME CMake option (apple#34018)
@gottesmm
Copy link
Member

@gottesmm gottesmm commented Sep 23, 2020

Looks reasonable to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.