Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix local relative project dir #1296
Open
Conversation
codecov-io
commented
Nov 14, 2019
•
Codecov Report
@@ Coverage Diff @@
## master #1296 +/- ##
==========================================
+ Coverage 96.21% 96.21% +<.01%
==========================================
Files 28 28
Lines 5305 5312 +7
Branches 677 677
==========================================
+ Hits 5104 5111 +7
Misses 130 130
Partials 71 71
Continue to review full report at Codecov.
|
stealthycoin
force-pushed the
stealthycoin:fix-local-relative-project-dir
branch
from
f1e7a45
to
e59f3fb
This removes the --project-dir argument and its following positional arg before passing to the child process. Since the child process inherits the parent's working directory, and we already used os.chdir to switch to the correct one there is no use for this argument anymore. Absolute paths will not break anythign since they will point to the same directory. Relative ones will break since they will be appended once more to CWD (which was already correct). Producing a path with the relative bit at the end twice.
stealthycoin
force-pushed the
stealthycoin:fix-local-relative-project-dir
branch
from
e59f3fb
to
ef72340
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
stealthycoin commentedNov 14, 2019
Fixes #1295