Skip to content
#

chemistry

Here are 840 public repositories matching this topic...

baoilleach
baoilleach commented Jan 21, 2018

Line 208 of molchrg.cpp has:

            if (EQ(atom->GetType(),"Npl") || EQ(atom->GetType(),"Nam"))

Gasteiger charge calculation should always return the same results for the same structure. However, the string returned by GetType() is set to an arbitrary value by an atom typer (or indeed the user), and so the results will change.

Line 208 should be rewritten to avoid using GetType

amarkpayne
amarkpayne commented May 6, 2020

Bug Description

See #1939 for more details. Whenever we significantly change RMG-database, the comments in the chemkin file need to be updated or else this uncertainty IPython notebook example will be broken. It is not ideal to continually update this file, so we should come up with a better solution. Possibilities include:

  1. Only update this file every major release. Add a note in the IP

Improve this page

Add a description, image, and links to the chemistry topic page so that developers can more easily learn about it.

Curate this topic

Add this topic to your repo

To associate your repository with the chemistry topic, visit your repo's landing page and select "manage topics."

Learn more

You can’t perform that action at this time.