Skip to content

/ server

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce font size and remove bold of search empty content notice #22987

Open
Valdnet opened this issue Sep 21, 2020 · 6 comments
Open

Reduce font size and remove bold of search empty content notice #22987

Valdnet opened this issue Sep 21, 2020 · 6 comments
Labels
1. to develop design enhancement feature: search good first issue

Comments

@Valdnet
Copy link
Contributor

@Valdnet Valdnet commented Sep 21, 2020

I propose to change the font size and bold in "Start typing to search" for the text string:

obraz

Proposal for a change:

obraz

App:
Nextcloud 20.0.0 beta4
@kesselb
Copy link
Contributor

@kesselb kesselb commented Sep 21, 2020

cc @jancborchardt @skjnldsv
@jancborchardt
Copy link
Member

@jancborchardt jancborchardt commented Sep 21, 2020 •
edited

Yep, it indeed looks a bit off since it’s different from the emptycontent of Notifications, as well as the loading feedback of the Contacts menu.

Would look better with the same font size (standard text size) and non-bold as you say.

@skjnldsv if you point out where this would have to be changed, this would make for a nice "good first issue". :)
@jancborchardt jancborchardt changed the title Change the font size and bold in search Reduce font size and remove bold of search empty content notice Sep 21, 2020
@Valdnet
Copy link
Contributor Author

@Valdnet Valdnet commented Sep 21, 2020

@jancborchardt Responsible for this:

server/core/css/apps.scss

Lines 21 to 27 in d77d52d

h2 {
font-weight: bold;
font-size: 20px;
margin-bottom: 12px;
line-height: 30px;
color: var(--color-text-light);
}

This also affects the user's status in the Dashboard.
Issue: #22978
@vivienhennig
Copy link

@vivienhennig vivienhennig commented Sep 30, 2020

Hey, can I work on this?
@Valdnet
Copy link
Contributor Author

@Valdnet Valdnet commented Sep 30, 2020

@vivienhennig It would be very good to correct it 😉.

Hey, can I work on this?

Create a PR and wait for developer approval.
@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Oct 1, 2020

@skjnldsv if you point out where this would have to be changed, this would make for a nice "good first issue". :)

This is using the EmptyContent component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1. to develop design enhancement feature: search good first issue
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
@jancborchardt @kesselb @skjnldsv @Valdnet @vivienhennig
You can’t perform that action at this time.