Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign updatasets: add unit tests #32
Comments
|
I've been interested in contributing to this project for a while! Is it ok if I take a shot at this issue? |
|
Hi @Magalame , any contribution large or small is very welcome ^^ |
|
Hi again! |
|
@Magalame how would you use hashing for this ? |
|
I think I misunderstood the purpose of the issue, I thought it was to check the integrity of the data |
|
Actually I think there is a reasonable way to use hashing for this. We basically want unit tests to make sure that the functions in So a nice way to do that would be, approximately, for each data set: do
abas <- getDataset abalone
head abas `shouldBe` valueOfHeadOfAbas
last abas `shouldBe` valueOfLastOfAbas
force (hash abas) `shouldBe` fixedHashand then the same for It would have the advantage of partly solving #29. And Haskell has a nice |
|
ping @ocramz |
Some unit tests asserting e.g. the length or some other property of the datasets would be nice to have.