Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upbuild: run edge tests on browserstack #20662
Merged
+27
−30
Conversation
crisbeto
force-pushed the
crisbeto:karma-launchers-update
branch
2 times, most recently
from
940398a
to
37ba1c0
crisbeto
force-pushed the
crisbeto:karma-launchers-update
branch
9 times, most recently
from
55aa082
to
0f60f4c
Moves the Edge tests to Browserstack to avoid the recent issues with Saucelabs.
crisbeto
force-pushed the
crisbeto:karma-launchers-update
branch
from
0f60f4c
to
78b6d8d
crisbeto
changed the title
crisbeto
requested review from
devversion,
mmalerba and
angular/dev-infra-components
as
code owners
| @@ -354,23 +354,23 @@ export function crossEnvironmentSpecs( | |||
| }); | |||
|
|
|||
| it('should be able to hover', async () => { | |||
| const host = await harness.host(); | |||
| let classAttr = await host.getAttribute('class'); | |||
| const box = await harness.hoverTest(); | |||
crisbeto
Sep 27, 2020
•
Author
Member
I decided to change these tests to hover an element inside the host, instead of the host itself, because the first assertion, that ensures that the element doesn't start off as hovered, was breaking on Browserstack. What I think was going on is that it would put the cursor inside the viewport when the window is opened, throwing off our assertion since the host takes up most of the screen and the cursor would land on it.
I decided to change these tests to hover an element inside the host, instead of the host itself, because the first assertion, that ensures that the element doesn't start off as hovered, was breaking on Browserstack. What I think was going on is that it would put the cursor inside the viewport when the window is opened, throwing off our assertion since the host takes up most of the screen and the cursor would land on it.
|
LGTM |
|
LGTM |
mmalerba
merged commit 8b6aab1
into
angular:master
16 checks passed
16 checks passed
ci/angular: merge status
All checks passed!
cla/google
All necessary CLAs are signed
mmalerba
added a commit
that referenced
this pull request
Sep 29, 2020
Moves the Edge tests to Browserstack to avoid the recent issues with Saucelabs. (cherry picked from commit 8b6aab1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Moves the Edge tests to Browserstack to avoid the recent issues with Saucelabs.