PascalPrecht
Follow
Create your own GitHub profile
Sign up for your own profile on GitHub, the best place to host code, manage projects, and build software alongside 50 million developers.
Sign up
Pinned
867 contributions in the last year
Activity overview
Contributed to
status-im/nim-status-client,
embarklabs/embark,
embarklabs/blog
and 5 other
repositories
Contribution activity
October 2020
Created a pull request in status-im/nim-status-client that received 7 comments
fix: introduce validation for required address requests in tx previews
+76
−23
•
7
comments
- fix(Chat): ensure transaction bubbles are render on the correct side
- chore: remove sound options for now
- feat: allow users to turn of notification sounds
- feat: allow users to configure notification settings
- feat: allow for fetching messages older than 24 hours
- uiux(Chat): change channel background when hovering over them
- fix: don't allow users to start chats with themselves
- fix: ensure chats are ordered by last message timestamp
- fix(Chat): ensure local nicknames are propagated properly
- feat: introduce mnemonic recovery success modal
- uiux(Chat): add margin between group header messages and fetch-more b…
- uiux: set minimum window height and width
- uiux(Chat): remove sent badge
- feat(Chat): show 'no search results' message
- uiux: allow for changing app's fontsize
- fix: introduce validation for required address requests in tx previews
- fix: from/to account not showing correctly
- uiux(Chat): change channel background when hovering over them
- fix: "Generate new keys" not clickable
- fix: fix text in bubbles being too low
- fix: 1:1 chat command transactions "intrinsic gas too low"
Created an issue in status-im/nim-status-client that received 3 comments
Transaction bubble status icon is wrong when address is shared
When "accepting & sharing" an address for a user to send a transaction, the transaction bubble update its status toAddress shared, however, the ico…
3
comments
- Make chat commands for sending and receiving transactions work as expected
- Implement "ENS flow" of send/request transactions via chat commands
- Toast message shows blank loading icon
- Transaction bubble components need a small corner like text bubbles
- Add modal to select account when "accept & share" address in chat commands
- Transaction bubbles don't update their state to pending/completed
- Show warn icon in tx preview when receiver address isn't known
- Show "Address required" info when sending tx via chat command
- Remove or fix warn icon in transaction preview
- Transaction request bubble shows wrong title on state change
- Sender and recipient aren't shown in transaction preview when accepting tx request
- Remove wrong sender address in transaction preview (transaction request)
- Transaction bubble always renders on the left side of the chat screen