Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRefactor queue-proxy into testable units #6803
Comments
|
@markusthoemmes: Please ensure the request meets the requirements listed here. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
I'm interested in helping out. It would be great if we can discuss how we can decompose this so others can jump in as well. |
|
thank you @taragu I agree |
|
Talked to @savitaashture and @taragu. They are fine if I hand this to @dsimansk :) /assign @dsimansk |
|
/assign @vagababov |
|
Hi @markusthoemmes, I would love to help you to tackle this issue!
Can you please help me find a good place to start? |
|
It's kind of assigned to me :) |
|
Sorry @vagababov, didn't want to take over the issue. I just saw the label "help wanted" and thought you might be in need of help. |
|
@jeangnc not a problem. |
|
Also in our shared library repo: https://github.com/knative/pkg/issues?q=is%3Aissue+is%3Aopen++label%3Akind%2Fgood-first-issue+ |
The queue-proxy's
main.gofile contains a lot of stuff currently and is hard to test. We should decompose the queue-proxy where possible and move separate bits into packages to be able to better test and benchmark parts of the queue-proxy. There is likely also potential for synergies between the queue-proxy and the activator.Before somebody picks this up and send PRs: Let's please discuss what and how we move things and how to stage them incrementally. That'll be easier than going back and forth on a potentially large PR.