Skip to content

/ rows

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accepting CSV's fmtparams on `import_from_csv` #209

Open
wants to merge 2 commits into
base: develop
from
Open

Accepting CSV's fmtparams on `import_from_csv` #209

wants to merge 2 commits into from

Conversation

@berinhard
Copy link
Contributor

@berinhard berinhard commented Oct 24, 2016 •
edited

@turicas I didn't add tests yet and I'm opening this PR just to make sure if you're ok with this small change on the API would fix #208. Reference on python doc for CSV reader params.

The usage would be:

data = rows.import_from_csv(fd, fmtparams={'delimiter': ';'})

What do you think? If you're ok, I can add tests to this.

PS.: with this change, the old tests keep passing =)
berinhard added 2 commits Oct 24, 2016
@berinhard
Add dict parameter to emulate CSV.reader fmtparams params
6f61ef6
@berinhard
Add test to ensure behaviour
bd83f88
@turicas
Copy link
Owner

@turicas turicas commented Feb 20, 2017

@berinhard thanks for the PR and sorry for so long!
Do you think the best option would be use an inner dict to have formatting parameters?
I think it would be easier for the user if we have delimiter and other parameters just as csv.reader does. What do you think?
@eduardostalinho eduardostalinho mentioned this pull request Jul 27, 2017
Open
@turicas turicas force-pushed the turicas:develop branch 2 times, most recently from fa144f0 to bbb2c57 Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement plugin
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

`import_from_csv` doesn't respect CSV default `fmtparams` overwriting
2 participants
@berinhard @turicas
You can’t perform that action at this time.