Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd es-module build with smaller dist size #44
Conversation
added 2 commits
Feb 15, 2018
Make eslint happy again, and make rollup coupe with implicit 'index.js' import
|
Can you please resolve conflicts @HeyHugo ? Maybe it is wiser to move entirely to rollup instead of webpack? What do you think? Having both of them in place seems a little redundant to me |
|
Ok will fix conflicts. Yes building all bundles with rollup probably makes sense. I'll add this to the PR when I have some time soon. Currently the commonjs dist is bundled as a umd build. I'll make this bundle proper commonjs and add a umd build with .min.js extension. Sounds good? |
|
Any chance this can be merged in? I just realized the dist bundle is quite big as well. |
|
@fakiolinho will it be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
When I analysed my app bundle I saw that this package looked a bit too beefy and saw that it did not have an es-module dist plus I thought dist size could probably be made a bit smaller.
rollup-plugin-string is used to inline the svgs into the dist for es-modules.
Cheers!