Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.1.15b1 testing #5414

Open
ThomasWaldmann opened this issue Oct 13, 2020 · 5 comments
Open

1.1.15b1 testing #5414

ThomasWaldmann opened this issue Oct 13, 2020 · 5 comments

Comments

@ThomasWaldmann
Copy link
Member

@ThomasWaldmann ThomasWaldmann commented Oct 13, 2020

I made a new release 1.1.15b1 for testing, see there:

https://github.com/borgbackup/borg/releases/tag/1.1.15b1

As you see, the borg code is pretty much the same as in 1.1.14, but especially the binary building got some updates. Thus, primarily the binaries should get some testing, to find issues before I make the final 1.1.15 release later this year.

As they were made on debian stretch with libc 2.24, they will require a libc compatible to that.

The binary not working on linux dists with incompatible libc versions is expected.

Note: In 1.1.14 and before, binaries were built on debian jessie with libc 2.19.

This issue is about general feedback, there is also #5402 about performance and resource usage, please give such feedback there.

@noplanman
Copy link

@noplanman noplanman commented Oct 20, 2020

We've decided to build the ARM binaries for alpha and beta versions too 👍

You can find them at https://borg.bauerj.eu/?show-unstable

I'll be updating the build system to also include all 1.2.* alpha builds.

@mmarinez
Copy link

@mmarinez mmarinez commented Oct 23, 2020

Hi, I would like to work on this issue. Is there anything else I would need to know before starting the testing?

@ThomasWaldmann
Copy link
Member Author

@ThomasWaldmann ThomasWaldmann commented Oct 23, 2020

pyinstaller/pyinstaller#2357 see the last comment there, maybe test that, too.

Guess this might be interesting in the context of vorta calling borg as a subprocess. @m3nu

@ThomasWaldmann
Copy link
Member Author

@ThomasWaldmann ThomasWaldmann commented Oct 23, 2020

@mmarinez well, the biggest change is about how the binary is built / the glibc it is built for / the python version it bundles/uses, so guess testing should address primarily that.

@m3nu
Copy link
Contributor

@m3nu m3nu commented Nov 1, 2020

Guess this might be interesting in the context of vorta calling borg as a subprocess. @m3nu

For macOS I'm currently using the develop branch of PyInstaller due to this issue, which needs a bootloader with newer MACOSX_DEPLOYMENT_TARGET.

With this setup I didn't see any issue when calling subprocess on the Pyinstaller borg binary. I also tried building the borg binary with the official Pyinstaller version on PyPi. No issue either.

Maybe the linked issue is related to Linux or to single binary Pyinstaller executables. For Vorta and Borg on macOS we only use single directory binaries to get around macOS signing issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.