fix(Variables): Fix when properties are null #8165

MystK · 2020-09-01T18:53:18Z

I thought this qualifies for a small and obvious bug, so I did not open an issue.

What is happening is when my file is empty, reducedValue is null and throws an error that the variable could not be found. See error below.

  TypeError: Cannot read property 'XXXXXXXXXXXXXXXXXXXXXXX' of null
      at C:\dev\XXXXX\node_modules\serverless\lib\classes\Variables.js:891:40
      at tryCatcher (C:\dev\XXXXX\node_modules\bluebird\js\release\util.js:16:23)
      at Object.gotValue (C:\dev\XXXXX\node_modules\bluebird\js\release\reduce.js:157:18)
      at Object.gotAccum (C:\dev\XXXXX\node_modules\bluebird\js\release\reduce.js:144:25)
      at Object.tryCatcher (C:\dev\XXXXX\node_modules\bluebird\js\release\util.js:16:23)
      at Promise._settlePromiseFromHandler (C:\dev\XXXXX\node_modules\bluebird\js\release\promise.js:517:31)
      at Promise._settlePromise (C:\dev\XXXXX\node_modules\bluebird\js\release\promise.js:574:18)
      at Promise._settlePromiseCtx (C:\dev\XXXXX\node_modules\bluebird\js\release\promise.js:611:10)
      at _drainQueueStep (C:\dev\XXXXX\node_modules\bluebird\js\release\async.js:142:12)
      at _drainQueue (C:\dev\XXXXX\node_modules\bluebird\js\release\async.js:131:9)
      at Async._drainQueues (C:\dev\XXXXX\node_modules\bluebird\js\release\async.js:147:5)
      at Immediate.Async.drainQueues [as _onImmediate] (C:\dev\XXXXX\node_modules\bluebird\js\release\async.js:17:14)
      at processImmediate (internal/timers.js:456:21)
      at process.topLevelDomainCallback (domain.js:137:15)


          fix(Variables): Fix when properties are null

codecov-commenter · 2020-09-01T18:55:24Z

Codecov Report

Merging #8165 into master will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #8165   +/-   ##
=======================================
  Coverage   88.24%   88.24%           
=======================================
  Files         248      248           
  Lines        9424     9424           
=======================================
  Hits         8316     8316           
  Misses       1108     1108

Impacted Files	Coverage Δ
lib/classes/Variables.js	`99.72% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7aad819...e26f449. Read the comment docs.

medikoo

Thank you @MystK that's definitely a right call. Please see my suggestion, also do you think you can patch a regression test for this?

medikoo · 2020-09-02T09:04:27Z

lib/classes/Variables.js

@@ -949,7 +949,7 @@ class Variables {
          reducedValue = this.appendDeepVariable(reducedValue, subProperty);
        } else {
          // get mode
-          if (typeof reducedValue === 'undefined') {
+          if (typeof reducedValue === 'undefined' || reducedValue === null) {


Let's replace it with equivalent if (reducedValue == null)

fix(Variables): Fix when properties are null

Verified

This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.

GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits

Loading status checks…

e26f449

medikoo requested changes Sep 2, 2020

View changes

medikoo added bug cat/variable labels Sep 2, 2020

medikoo assigned MystK Sep 2, 2020

medikoo added help wanted good first issue labels Sep 9, 2020

serverless / serverless

fix(Variables): Fix when properties are null #8165

fix(Variables): Fix when properties are null #8165

MystK commented Sep 1, 2020 •

edited

codecov-commenter commented Sep 1, 2020

medikoo left a comment

This comment has been minimized.

serverless / serverless

Join GitHub today

fix(Variables): Fix when properties are null #8165

fix(Variables): Fix when properties are null #8165

Conversation

MystK commented Sep 1, 2020 • edited

codecov-commenter commented Sep 1, 2020

Codecov Report

medikoo left a comment

This comment has been minimized.

medikoo Sep 2, 2020 Member

MystK commented Sep 1, 2020 •

edited

medikoo Sep 2, 2020
Member