Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Prefix operation ids with parent id #1245
Conversation
|
@BBlowers thank you for your PR! Unfortunately, this is a breaking change. Old URLs will stop working. Would you have some time add support for old Let me know, I can pick this up. |
|
@RomanHotsiy good point. Supporting both |
|
@RomanHotsiy I've added the I've kept the changes to a minimum as I'm not too familiar with typescript. |
|
@RomanHotsiy is this PR likely to get another look soon? |
|
Hey @BBlowers, Sorry for the radio silence. I will review and merge it this week. This looks good. I just have to test if it doesn't break our other tools. |
|
@RomanHotsiy How did the tests go? Is this okay to be merged? |
|
Oh, sorry, not really. I haven't tested it yet. Thanks for pinging. I am now adding it to the team sprint board so we prioritize it. If it is not merged mid-next week - feel free to ping me again! Sorry, busy months for me :( |
|
I just tested it out and there is some conflict with our internal tool. It should be fixed early next week and I will merge after. |
|
any news? |
Currently, operations that have multiple tags appear multiple times on the page as desired, however, their containing elements share the same id. This means when using the side menu to navigate the user is always taken to the earliest occurrence.
To demonstrate I've added the
pettag to the "Returns pet inventories by status" operation in this gif. Clicking on the "Returns pet inventories by status" operation in the store section takes the user to the operation under the pet sectionA solution to this is to prefix operation ids with their parent's id.