Skip to content

/ react

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move MS Windows build to CircleCI #17984

Merged
merged 2 commits into from Mar 13, 2020
+45 −42
Merged

Move MS Windows build to CircleCI #17984

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec5d128
Move MS Windows build to CircleCI
Feb 5, 2020
a09d7cd
Update to latest NodeJS
Feb 6, 2020
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

46 .circleci/config.yml
View file
Open in desktop
@@ -1,4 +1,7 @@
version: 2
version: 2.1

orbs:
win: circleci/windows@2.4.0

aliases:
- &docker
@@ -48,6 +51,9 @@ aliases:
paths:
- bundle-sizes.json

- &ms_windows_environment
JAVA_HOME: C:\Program Files\Java\jdk1.8.0

jobs:
setup:
docker: *docker
@@ -352,6 +358,38 @@ jobs:
RELEASE_CHANNEL: experimental
command: yarn test-build-prod --maxWorkers=2

test_ms_windows:
executor:
name: win/default
environment: *ms_windows_environment
steps:
- run:
# Fix line endings in Windows.
command: git config --global core.autocrlf input
Comment on lines +367 to +368

This comment has been minimized.

Sign in to view
@zpao

zpao Feb 6, 2020
Member

😑 Do we need to do this if we aren't making any commits? Also, doesn't input really only map to *nix use? (https://git-scm.com/book/en/v2/Customizing-Git-Git-Configuration#_code_core_autocrlf_code)

This comment has been minimized.

Sign in to view
@wittgenst

wittgenst Feb 6, 2020
Author Contributor

This was copied from the AppVeyor config. We can try if it works without.
- checkout
- restore_cache:
keys:
- v2-win-node-{{ arch }}-{{ .Branch }}-{{ checksum "yarn.lock" }}
- v2-win-node-{{ arch }}-{{ .Branch }}-
- v2-win-node-{{ arch }}-
Comment on lines +370 to +374

This comment has been minimized.

Sign in to view
@zpao

zpao Feb 6, 2020
Member

Should this just be - *restore_yarn_cache? Looks like that's what is used elsewhere for this step.

This comment has been minimized.

Sign in to view
@wittgenst

wittgenst Feb 6, 2020
Author Contributor

We are using a different cache key for Win and Linux, since the files and folders might not be exactly the same - so we can't use the same restore step.
- run:
command: node --version
- run:
command: choco install yarn
- *run_yarn
- save_cache:
key: v2-win-node-{{ arch }}-{{ .Branch }}-{{ checksum "yarn.lock" }}
paths:
- C:\Users\circleci\AppData\Local\Yarn
- run:
command: yarn lint
- run:
command: yarn build
- run:
command: yarn test
- run:
command: yarn prettier

workflows:
version: 2
stable:
@@ -439,3 +477,9 @@ workflows:
- test_fuzz:
requires:
- setup

ms_windows:
jobs:
- test_ms_windows


41 appveyor.yml
View file
Open in desktop

This file was deleted.

ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.