Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign up[SPARK-33234][INFRA] Generates SHA-512 using shasum #30123
Closed
Conversation
Which makes the hash much easier to verify for users that don't have GPG.
|
Can one of the admins verify this patch? |
dongjoon-hyun
changed the title
|
+1, LGTM. Thank you, @emilianbold . I tested |
|
What is your JIRA id, @emilianbold ? |
|
Not sure what you mean, my Apache JIRA ID or what JIRA ID? Also, I wonder,
what for?
…--emi
On Mon, Oct 26, 2020 at 2:08 AM Dongjoon Hyun ***@***.***> wrote:
What is your JIRA id, @emilianbold <https://github.com/emilianbold> ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#30123 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHSCQVACKKPQM7HWJ4KHMLSMS4WHANCNFSM4S2NIYFA>
.
|
|
@emilianbold, Apache JIRA ID because the ticket (SPARK-33234) has to be assigned properly to you. |
|
Your Apache JIRA ID, @emilianbold . As a recognition of your contribution, I want to assign SPARK-33234 to you as @HyukjinKwon explained. |
|
Apparently my JIRA ID is emi
Regards,
…--emi
On Mon, Oct 26, 2020 at 5:25 AM Dongjoon Hyun ***@***.***> wrote:
Your Apache JIRA ID, @emilianbold <https://github.com/emilianbold> . As a
recognition of your contribution, I want to assign SPARK-33234
<https://issues.apache.org/jira/browse/SPARK-33234> to you as @HyukjinKwon
<https://github.com/HyukjinKwon> explained.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#30123 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHSCQVBFAD3INNICBAFWLTSMTT3JANCNFSM4S2NIYFA>
.
|
|
?
|
|
Hm, this is what JIRA says:
Here are the details of your account:
---------------------------------------------------------------------
Username: emi
Email: [email protected]
Full Name: Emilian Bold
…--emi
On Mon, Oct 26, 2020 at 9:53 AM Dongjoon Hyun ***@***.***> wrote:
?
[image: Screen Shot 2020-10-26 at 12 51 52 AM]
<https://user-images.githubusercontent.com/9700541/97146674-78a15580-1725-11eb-8f1f-15d6e65cdd24.png>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#30123 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHSCQSL2WXQT4GLAZ7QYCTSMUTHLANCNFSM4S2NIYFA>
.
|
|
Finally, I assigned SPARK-33234 to you. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
What changes were proposed in this pull request?
I am generating the SHA-512 using the standard shasum which also has a better output compared to GPG.
Why are the changes needed?
Which makes the hash much easier to verify for users that don't have GPG.
Because an user having GPG can check the keys but an user without GPG will have a hard time validating the SHA-512 based on the 'pretty printed' format.
Apache Spark is the only project where I've seen this format. Most other Apache projects have a one-line hash file.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
This patch assumes the build system has shasum (it should, but I can't test this).