Report which variable fails interpolation when they are mandatory #7866
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luca-nardelli
requested review from
aiordache,
ndeloof,
rumpl and
ulyssessouza
as code owners
Add default value before raising UnsetRequiredSubstitution Signed-off-by: Luca Nardelli <[email protected]>
luca-nardelli
force-pushed
the
improve-mandatory-variables-issues
branch
from
6e4e8ec to
d51249a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the error reporting while interpolating by providing a default error message for mandatory variables when they are not set. The default error message corresponds to the name of the variable itself, so it's easier to point out where the issue is.
I have updated the relevant test accordingly.
This was a quick wordaround to get the variable name in the error message, but if you have other ideas for formatting the error please let me know and I'll see what I can do!
Signed-off-by: Luca Nardelli [email protected]
Resolves #7504