Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include git commit in package and model meta #5694

Merged
merged 3 commits into from Jul 2, 2020

Conversation

@adrianeboyd
Copy link
Member

@adrianeboyd adrianeboyd commented Jul 2, 2020

Description

Include git commit in package and model meta

  • save current git commit in spacy/git_info.py
  • include current git commit in meta.json when models are saved
  • git version code in setup.py is adapted from numpy, add licenses/3rd_party_licenses.txt with relevant license

Types of change

Enhancement

Checklist

  • I have submitted the spaCy Contributor Agreement.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.
@adrianeboyd
Copy link
Member Author

@adrianeboyd adrianeboyd commented Jul 2, 2020

I didn't want to call it version.py because our version is in about.py and I didn't want it to be confusing, but git_info.py is easy to change here.

adrianeboyd added 2 commits Jul 2, 2020
@honnibal honnibal merged commit 971826a into explosion:master Jul 2, 2020
10 checks passed
10 checks passed
explosion.spaCy Build #20200702.13 succeeded
Details
explosion.spaCy (Test Python35Linux) Test Python35Linux succeeded
Details
explosion.spaCy (Test Python35Windows) Test Python35Windows succeeded
Details
explosion.spaCy (Test Python36Linux) Test Python36Linux succeeded
Details
explosion.spaCy (Test Python36Mac) Test Python36Mac succeeded
Details
explosion.spaCy (Test Python36Windows) Test Python36Windows succeeded
Details
explosion.spaCy (Test Python38Linux) Test Python38Linux succeeded
Details
explosion.spaCy (Test Python38Mac) Test Python38Mac succeeded
Details
explosion.spaCy (Test Python38Windows) Test Python38Windows succeeded
Details
explosion.spaCy (Validate) Validate succeeded
Details
@adrianeboyd adrianeboyd mentioned this pull request Aug 24, 2020
3 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.