Skip to content

/ act

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support custom GITHUB_RUN_ID, GITHUB_RUN_NUMBER #369

Merged
merged 5 commits into from Sep 22, 2020
Merged

feat: support custom GITHUB_RUN_ID, GITHUB_RUN_NUMBER #369

merged 5 commits into from Sep 22, 2020

Conversation

@theowenyoung
Copy link
Contributor

@theowenyoung theowenyoung commented Sep 19, 2020

Hi, I have a problem with GITHUB_RUN_ID.

the action actions/upload-artifact need to use GITHUB_RUN_ID, but act define it to 1, I suspect if there is a way to pass in a custom value, like use .env GITHUB_RUN_ID?

I submit a pr for this, would you give some advice?

jobs:
  print:
    name: test
    runs-on: ubuntu-latest
    steps:
      - uses: actions/upload-artifact@v2
         with:
           name: test
           path: ./test.txt
theowenyoung added 3 commits Sep 1, 2020
@theowenyoung
feat: add fromJSON support
Loading status checks…
9c43bee
@theowenyoung
Merge branch 'master' of github.com:nektos/act
6860769
@theowenyoung
feat: support custom runId and runNumber
Loading status checks…
ea6989d
@theowenyoung theowenyoung requested a review from cplee as a code owner Sep 19, 2020
@theowenyoung
chore: manual update
Loading status checks…
efe4122
@theowenyoung
chore: lint
Loading status checks…
4cf66f3
@cplee
cplee approved these changes Sep 22, 2020
View changes
@cplee cplee merged commit 1070c58 into nektos:master Sep 22, 2020
4 checks passed
4 checks passed
lint
Details
test
Details
snapshot
Details
release
Details
@theowenyoung
Copy link
Contributor Author

@theowenyoung theowenyoung commented Sep 27, 2020

Hi, @cplee , Thanks for merging the pr. May I known what time of the next release version? A project of mine rely act and I need this feature.

Thanks again!
@twpayne twpayne mentioned this pull request Sep 28, 2020
Merged
@cplee
Copy link
Contributor

@cplee cplee commented Sep 28, 2020

@theowenyoung just released 0.2.15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cplee cplee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@theowenyoung @cplee
You can’t perform that action at this time.