Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upIntroduce minPoints option #156
Merged
+722
−23
Conversation
This was referenced Jun 2, 2020
| } else { // left points as unclustered | ||
| clusters.push(p); | ||
|
|
||
| if (numPoints > 1) { |
zmiao
Jun 3, 2020
I am curious why we compare numPoints with 1 instead of numPointsOrigin?
I am curious why we compare numPoints with 1 instead of numPointsOrigin?
mourner
Jun 3, 2020
Author
Member
When numPointsOrigin is bigger than 1, it means that the origin is itself a cluster, which could only be formed from minPoints points or more. So in case of origin cluster, we never reach this else case (numPoints will always be >= minPoints).
When numPointsOrigin is bigger than 1, it means that the origin is itself a cluster, which could only be formed from minPoints points or more. So in case of origin cluster, we never reach this else case (numPoints will always be >= minPoints).
zmiao
Jun 3, 2020
I see! Thank you!
I see! Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Adds an option to set the minimum points required to form a cluster (
2by default).