Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upfeature(login) keep session living #444
Open
Conversation
|
@DaftMonk, I understand why you said it didn't work for you. I didn't checked if my PR works for FB, G+ or Tw. I have found my mistake: |
…he admin page Changes: - use User.query() in admin.controller instead of $http
…ing uibootstrap Changes: (only if ui-bootstrap is selected) - add `client/components/modal` folder - modal folder contains service, markup template, and stylesheet - modal service is intended to be extended, comes with `Modal.confirm.delete()` method - admin and main page will both use `Modal.confirm.delete()` Todo: - review code for cleanliness and correctness - possibly extend the modal service to include a basic alert class? - write test for `Modal` service?
Changes: - Update jshint task in `Gruntfile.js` to include `serverTest` - Add `server/.jshintrc-spec` that extends `server/.jshintrc` with spec globals - Use `"latedef": "nofunc"` instead of `"latedef": true` in `server/.jshintrc` - Add assertion for `jshint` task in generator tests for `defaultOptions` - Fix pre exsisting lint errors in `server` and `client` - Change `getEmail()` in `client/app/account/settings/settings.controller` to use `user` arg and not `$scope.user` Closes #463, #486
This reverts commit ef06272. Conflicts: app/templates/client/app/account(auth)/settings/settings.controller(coffee).coffee app/templates/client/app/account(auth)/settings/settings.controller(js).js app/templates/client/app/admin(auth)/admin(html).html app/templates/client/app/admin(auth)/admin(jade).jade app/templates/client/app/admin(auth)/admin.controller(coffee).coffee app/templates/client/app/admin(auth)/admin.controller(js).js app/templates/server/api/user(auth)/user.controller.js app/templates/server/api/user(auth)/user.model.js app/templates/server/auth(auth)/facebook(facebookAuth)/index.js app/templates/server/auth(auth)/facebook(facebookAuth)/passport.js app/templates/server/auth(auth)/google(googleAuth)/index.js app/templates/server/auth(auth)/google(googleAuth)/passport.js app/templates/server/config/_local.env.js app/templates/server/config/environment/index.js
|
Now, tests are passing and localStorage works for local, FB, G+ and Tw. |
Session token is valid for 30 days and will be stored in browser's local storage until user log out. - replace ngCookie by ngStorage - replace $cookie by $localStorage - add token duration parameter in config file - add role in signToken
Closed
|
When can we expect this to be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Session token is valid for 30 days and will be stored in browser's local storage until user logs out.